This repository has been archived by the owner on Dec 27, 2023. It is now read-only.
forked from nus-cs2103-AY2324S1/tp
-
Notifications
You must be signed in to change notification settings - Fork 4
Update my PPP #205
Merged
rayshawntan
merged 3 commits into
AY2324S1-CS2103-W14-3:master
from
rayshawntan:project-portfolio-page
Nov 10, 2023
Merged
Update my PPP #205
rayshawntan
merged 3 commits into
AY2324S1-CS2103-W14-3:master
from
rayshawntan:project-portfolio-page
Nov 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #205 +/- ##
=========================================
Coverage ? 72.40%
Complexity ? 439
=========================================
Files ? 76
Lines ? 1482
Branches ? 144
=========================================
Hits ? 1073
Misses ? 367
Partials ? 42 |
Cloud7050
approved these changes
Nov 10, 2023
docs/team/rayshawntan.md
Outdated
|
||
## Contributions to the user guide (extracts) | ||
### Contributions beyond the project team | ||
* During PE-D, I have put in efforts to [find bugs](https://github.com/AY2324S1-CS2103T-T09-4/tp/issues?q=is%3Aissue+%22%5BPE-D%5D%5BTester+D%5D%22) that do not correspond to their UG. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Potential typo in "efforts"?
### Contributions to the UG | ||
|
||
* Update implementations of `add` and `edit` features |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There may be a bit of inconsistency in the pointers that do or don't end with fullstops.
bwangpj
approved these changes
Nov 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rayshawntan you can merge whenever you are ready
mamayuan
approved these changes
Nov 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update my PPP draft. Not fully complete yet, but to be released to meet tP dashboard deadline.