Ppp final #558
Merged
Ppp final #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 'master' of https://github.com/AY2324S1-CS2103T-T13-3/tp: (35 commits) Change Model Implementation and Add ID Add search and fix PE Fix the tests and further code quality issue Add logging and assertions Add guard Add empty preamble and logs Add links Fix test cases Fix LoD and add logging Fix checkstyle Add assert/logger statements Add More Testing for missing pathways Cleanup uml Refractor ReadOnlyBook Model Fix ModelClassDiagram Clean List Command Update parser name Update DeliveryList and DeliveryView Rename sortFilteredDeliveryList Fix Sort SLAP ...
* 'master' of https://github.com/AY2324S1-CS2103T-T13-3/tp: (57 commits) Update final PPP Format DG Update Benjamin PPP Final line EOF Update DG - Refine Content Update UG Update PPP Change all predicates Fix optional Remove imports Refractor methods Add Author Add extra test cases to codebase Add back missing update delivery Clean checkstyle Update UG print Fix Checkstyle Add Test Coverage for non-trivial paths Add Test Coverage for non-trivial paths Cleanup transformer ...
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #558 +/- ##
=========================================
Coverage 85.30% 85.30%
Complexity 1028 1028
=========================================
Files 121 121
Lines 3164 3164
Branches 371 371
=========================================
Hits 2699 2699
Misses 354 354
Partials 111 111 ☔ View full report in Codecov by Sentry. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.