Skip to content

Commit

Permalink
Fix Checks
Browse files Browse the repository at this point in the history
  • Loading branch information
thienmy0 committed Nov 13, 2023
1 parent d42ee5d commit 6c43d29
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 20 deletions.
8 changes: 4 additions & 4 deletions docs/DeveloperGuide.md
Original file line number Diff line number Diff line change
Expand Up @@ -428,9 +428,9 @@ It then returns a `CommandResult` stating that the patient has been edited.
* **Alternative 1 (current choice):** Create `EditPatientDescriptor` to set the patient attributes
to their edited values, and create an edited Patient object to replace the target Patient object
through the `edit` command.
* Pros: Better practice in large codebases through defensive programming, ensuring
* Pros: Better practice in large codebases through defensive programming, ensuring
values of parameters not edited are retained
* Cons: Not as easy to implement as it entails making nested classes
* Cons: Not as easy to implement as it entails making nested classes
for patient descriptors and calling setter methods to make a new edited Patient object

<br>
Expand All @@ -439,8 +439,8 @@ It then returns a `CommandResult` stating that the patient has been edited.
* Pros: Easier to implement as it entails directly calling a Patient constructor
that accepts the user input. Therefore it modifies the original Patient object
instead of creating a whole new edited Patient object.
* Cons: This may be harmful as the fields that remain unchanged will be overwritten by
default values. The alternative would be to input the values of the unchanged fields into the
* Cons: This may be harmful as the fields that remain unchanged will be overwritten by
default values. The alternative would be to input the values of the unchanged fields into the
Patient constructor as well, but this will be inefficient, repetitive and not be as user-friendly.

<br>
Expand Down
2 changes: 1 addition & 1 deletion docs/UserGuide.md
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ Used to highlight issues to look out for
3. Download Advanced&Efficient [here](https://github.com/AY2324S1-CS2103T-T14-2/tp/releases/tag/v1.4)<br>
i. After clicking on the link, click on `AdvancedAndEfficient.jar` as seen in the picture below.

<img src='images/ug/jar.png' width='600'>
<img src='images/ug/jar.png' width='600'>
<br>

4. After downloading the application, move it into the “AAndE” folder created in step 2.
Expand Down
30 changes: 15 additions & 15 deletions docs/team/riyamehta2211.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,41 +15,41 @@ Given below are my contributions to the project.

### New Features

1. **New Feature**: Added Redo and Undo commands to convert to
1. **New Feature**: Added Redo and Undo commands to convert to
the previous or the next state of the patient AddressBook
([#167](https://github.com/AY2324S1-CS2103T-T14-2/tp/pull/167))

1. **What Undo does:** Allows commands which modify state of the AddressBook to be undone
2. **Justification:** Users may mistakenly enter commands which modify the state of the AddressBook.
The Undo feature gives the facility of undoing the state of the AddressBook

2. **Justification:** Users may mistakenly enter commands which modify the state of the AddressBook.
The Undo feature gives the facility of undoing the state of the AddressBook
by reversing the commands performed.

3. **Additional Details:**
* **What Redo does:** Acts as a complement for the Undo feature
* **Justification:** Users may accidentally undo a significant change done to
the AddressBook. Redo feature acts as a complement and helps redo a previously
undone modification to the AddressBook.
* **Justification:** Users may accidentally undo a significant change done to
the AddressBook. Redo feature acts as a complement and helps redo a previously
undone modification to the AddressBook.
* Added comprehensive Testing for Undo and Redo Command Classes
([#224](https://github.com/AY2324S1-CS2103T-T14-2/tp/pull/224))

4. **Highlights:** Modified execution of the different Commands to commit
4. **Highlights:** Modified execution of the different Commands to commit
to the AddressBook history. This way, the Undo and Redo functions
are implemented to inherently modify the AddressBook state itself,
rather than individual Commands.

2. **New Attributes:** Added Birthday and IcNumber Attributes
([#89](https://github.com/AY2324S1-CS2103T-T14-2/tp/pull/89))
* **Justification:** Birthdates and IC Numbers are compulsory fields of information
* **Justification:** Birthdates and IC Numbers are compulsory fields of information
which have to be stored in the records of the patients.
* **Highlight:** Used LocalDateTime to accept valid birthdates of patients for the logging of
* **Highlight:** Used LocalDateTime to accept valid birthdates of patients for the logging of
patients into the AddressBook. Valid user inputs would be automatically formatted into valid dates.

3. **New Feature**: Added AssignedDepartment into Storage
([#107](https://github.com/AY2324S1-CS2103T-T14-2/tp/pull/107))
* **Justification:** This is to ensure that the department the patient has been assigned to is also saved
in Storage and available for access when A&E is closed and reopened.


-------

Expand All @@ -58,8 +58,8 @@ Given below are my contributions to the project.
1. **Enhancements to existing features**: Enhanced Delete and Edit features
* **Explanation:** Delete and Edit features now access patient list using IC Number instead of list index
* **Highlight:** More user-friendly as users can now delete and edit patients using their
IC Number instead of the list index. Especially useful in extremely large record systems
where it can be troublesome to locate the exact index of the patient. It is more convenient to search
IC Number instead of the list index. Especially useful in extremely large record systems
where it can be troublesome to locate the exact index of the patient. It is more convenient to search
and delete or edit the patient using the IC Number.
* **Enhanced Edit Feature:** ([#145](https://github.com/AY2324S1-CS2103T-T14-2/tp/pull/145))
* **Enhanced Delete Feature:** ([#120](https://github.com/AY2324S1-CS2103T-T14-2/tp/pull/120))
Expand Down Expand Up @@ -97,4 +97,4 @@ Given below are my contributions to the project.
* Reviewed and merged various PRs made by team members
* Here are some of the PRs I have reviewed (with non-trivial review comments):
([#240](https://github.com/AY2324S1-CS2103T-T14-2/tp/pull/240)),
([#102](https://github.com/AY2324S1-CS2103T-T14-2/tp/pull/102))
([#102](https://github.com/AY2324S1-CS2103T-T14-2/tp/pull/102))

0 comments on commit 6c43d29

Please sign in to comment.