Add Record JSON Storage Format to DG
#132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update project from team repo
Update project from team repo
Revert "Update project from team repo"
Update project from team repo
Update project from team repo
Implement JsonAdaptedRecord to enable JSON serialization for patient records. Update JsonSerializableAddressBook to work with new serialization. Enhance AddressBook model to support new serialization functionality. Introduce UniqueRecordList for ensuring record uniqueness.
- Test default constructor for Record. - Validate initialization with default values for fields. - Test setters and getters for initialObservations, diagnosis, treatmentPlan. - Ensure correct behavior of equals method.
- Detailed the JSON representation of the `Record` class. - Provided an example JSON format with explanations for each field. - Highlighted the default values used for certain fields when no data is provided.
thienmy0
approved these changes
Oct 27, 2023
| import seedu.address.storage.Storage; | ||
| import seedu.address.storage.StorageManager; | ||
| import seedu.address.storage.UserPrefsStorage; | ||
| import seedu.address.storage.*; |
There was a problem hiding this comment.
Perhaps * import statements should be avoided?
| } | ||
| ``` | ||
|
|
||
| #### Explanation: |
There was a problem hiding this comment.
I like how you added the explanation about how you integrated Record into Storage!
| @@ -3,17 +3,48 @@ | |||
| } | |||
|
|
|||
| #copyButton { | |||
| -fx-background-color: dimgray; | |||
| -fx-background-color: #3C4EEF; | |||
There was a problem hiding this comment.
I like how you adapted our UI to look more like the design Jingya made:)
This was referenced Oct 27, 2023
This was referenced Oct 27, 2023
Closed
wujy28
approved these changes
Oct 27, 2023
| @@ -3,17 +3,48 @@ | |||
| } | |||
|
|
|||
| #copyButton { | |||
| -fx-background-color: dimgray; | |||
| -fx-background-color: #3C4EEF; | |||
| * to ensure that the record being added or updated is | ||
| * unique in terms of identity in the UniqueRecordList. | ||
| */ | ||
| public class UniqueRecordList implements Iterable<Record> { |
There was a problem hiding this comment.
Neat way to store all the records in the system!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
RecordJSON Storage Format to DGKey Changes:
Recordclass.