Update project from team repo #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, Patient class is taking in Department and Record as input Department and Record are to be created when Patient is created, thus it shouldnt be an input Update Patient constructor to remove AssignedDepartment and Record parameters, also initialiazed them with default values
Currently, the instantiation of Record class does not initialise default values for other fields. This means that if a particular program wants to get its attribute value, it could lead to null value. Update Record.java to include 3 default initialization values for its fields
Currently, the sample patients are using outdated fields. It is important to update the patients to use the new fields. Add the Gender, IcNumber and Birthday fields to sample Patients
Edit EditCommand.java, EditCommandParser.java, and ParserUtil.java so that we can edit the patient information and its record.
Branch update patient fields
Update EditCommand.java, EditCommandParser.java, and ParserUtil.java
Update AddCommandParser to integrate ParserUtil
Currently, the EditCommand and EditCommandParser classes are inconsistent in that they contain methods that process patient attributes that are not parameters into the Edit command, or certain parts lack the processing of important attributes. Fixing this issue will prevent further bugs and lead to neater code. Let's, * Add and remove attributes in the two classes for consistency * Make sure that important attributes are mentioned in parts that were previously lacking them
There is an issue where after PatientBuilder() is called, it will call RecordBuilder(), which in turn calls PatientBuilder() again, causing a StackOverflow error. We need to fix this to get our test cases to pass. Let's * Add a new constructor to RecordBuilder that takes in a PatientBuilder to initialize its patient, instead of calling PatientBuilder again * Add new attributes to TypicalPatients Note that not all of the fields in Typical Patients are updated! AMY and BOB still need to be updated, which involves adding new attributes into CommandTestUtilgit add --all
The existing console messages do not display the new attributes, confusing the user as to what attributes are available. Adding them to the messages allow them to view all the patient's attributes even without the updated GUI. Let's update the Add command and patient messages.
Fix Issues in Edit Command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.