Make Edit Command Parser with i/ prefix in user input #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's modify the Edit Command Parser and the corresponding test cases to parse raw user inputs without the command word
AaronJT1
approved these changes
Oct 31, 2023
| @@ -35,9 +33,9 @@ public DeleteCommand(IcNumber icNumber) { | |||
| @Override | |||
| public CommandResult execute(Model model) throws CommandException { | |||
| requireNonNull(model); | |||
| List<Patient> lastShownList = model.getFilteredPatientList(); | |||
| List<Patient> currentPatientList = model.getCurrentPatientList(); | |||
There was a problem hiding this comment.
Nice that you are using the currentPatient list!
| import java.util.Collections; | ||
| import java.util.Optional; | ||
| import java.util.Set; | ||
| import java.util.*; |
There was a problem hiding this comment.
Would be good to disable the import * functionality
There was a problem hiding this comment.
See that you have updated the test cases as specified in previous pr good job!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's modify the Edit Command Parser and the corresponding test cases to parse raw user inputs without the command word