-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Branch update ug #240
Branch update ug #240
Conversation
Currently, the user guide is outdated and does not have a proper faq section It is important to update the faq section accordingly as the product grow Update the faq section of user guide
Currently, my PPP when converted to pdf exceeds 2 pages It is important to stick within the page limit Update the PPP to reduce page count
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job with the changes made in the UG and the PPP! Left a few suggestions on modifications to be made in the UG but other than that LGTM!
3. If you have Java installed, you should see your Java version as shown underlined in the picture below. | ||
<img src='images/javaversion.png' width='500'> | ||
4. If you do not have Java or your Java version is below 11, install Java | ||
11 [here](https://www.oracle.com/java/technologies/downloads/#java11) | ||
|
||
|
||
2. Go to your Desktop and create a folder named “A&E”. | ||
2. Go to your Desktop and create a folder named “AAndE”. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for standardizing the format of the name of the folder and all throughout!
application. | ||
|
||
**Q**: I have a list of patients, how do i view their details?\ | ||
**A**: Please click on the patient you are interested in viewing. The details will be on the right hand side in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can use similar phrasing as lines 231-232 as the point is the same for consistency. Though this is just a minor suggestion and not really an issue
docs/UserGuide.md
Outdated
**A**: Please click on the patient you are interested in viewing. The details will be on the right hand side in the | ||
Patient Record Panel. | ||
|
||
**Q**: The Patient List Panel is cut off, i cant see some details for each patient\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think for the qn here, the "i" can be capitalized and can't should have a ', just for consistency in the user guide haha
docs/UserGuide.md
Outdated
|
||
**Q**: The Patient List Panel is cut off, i cant see some details for each patient\ | ||
**A**: Please resize the application by dragging the border of the application window with your mouse. | ||
If the appplication is already in full screen mode, please drag the divider between the Patient List Panel and Patient |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A typo for application in line 433, but other than that, the phrasing is good!
docs/UserGuide.md
Outdated
If the appplication is already in full screen mode, please drag the divider between the Patient List Panel and Patient | ||
Record Panel to the right. | ||
|
||
**Q**: I entered a command and there is no response from the application, what do i do?\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar suggestion on the capitalization of I, other than that, good job on the FAQs!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall but do take a look at the comments! Thanks for updating the UG 👍
docs/UserGuide.md
Outdated
**Caution:** Duplicate patients are not allowed. Duplicate patients refer to patients with the same name and/or IC | ||
number. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We planned to have these in boxes rather than just bolding the Caution/Note/Tip right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to https://markbind.org/userGuide/components/presentation.html I think the code would be something like the following?
<box type="info">
info
</box>
<box type="warning">
warning
</box>
<box type="tip">
tip
</box>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok will take note of that!
docs/UserGuide.md
Outdated
number. | ||
|
||
- Names are case-sensitive | ||
- Han Bo is different from han bo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps "Han Bo" and "han bo" should be Han Bo
and han bo
instead, such that it is more in line with our Google Doc UG? same for IC number below
**A**: Yes, A&E saved your data after every command executed. | ||
|
||
**Q**: How do I transfer my data to another Computer?\ | ||
**A**: Install the app in the other computer and overwrite the empty data file it creates with the file that contains |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we could be clearer on this "data file" part in case users do not understand what it is and how to overwrite it?
docs/UserGuide.md
Outdated
**A**: Yes, A&E has the [Undo](#undoing-a-command--undo) feature which allows you to retrieve all the lost details. | ||
|
||
**Q**: Will my data be saved immediately?\ | ||
**A**: Yes, A&E saved your data after every command executed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps there is a grammatical error here and it should be "saves" rather than "saved"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got it
docs/UserGuide.md
Outdated
the technical team in charge of your department to file a bug report on our [issues](tps://github.com/AY2324S1-CS2103T-T14-2/tp/issues) page. | ||
|
||
**Q**: I have accidentally cleared the whole patient record system, can i retrieve the lost details?\ | ||
**A**: Yes, A&E has the [Undo](#undoing-a-command--undo) feature which allows you to retrieve all the lost details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the link to undo might be wrong as it should be one dash(-) instead of two
docs/UserGuide.md
Outdated
Q: How do I transfer my data to another Computer? | ||
A: Install the app in the other computer and overwrite the empty data file it creates with the file that contains the | ||
data of your previous A&E home folder. | ||
**Q**: I double-clicked the Jar file and it doesnt run, why?\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps you are missing an apostrophe for "doesn't"?
**Q**: How do I transfer my data to another Computer?\ | ||
**A**: Install the app in the other computer and overwrite the empty data file it creates with the file that contains | ||
the data of your previous AAndE home folder. | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps you are missing a link back to the Table of Contents after FAQs?
Currently there are some typo and mistakes in the UG. It is important to fix this typo constantly Update UG to take into account comments
32fe2fd
into
AY2324S1-CS2103T-T14-2:master
Summary of change
Update user guide for parts allocated and update PPP to hit page count
Key changes
User Guide
PPP