Update moving of prescriptions to completed list #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jingyu987
added
type.Task
|
halp i dont understand the tests that are failing idk why fail :( |
RoeReRe
requested changes
Oct 25, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #129 +/- ##
============================================
- Coverage 70.18% 70.17% -0.01%
Complexity 546 546
============================================
Files 94 94
Lines 1972 1968 -4
Branches 230 229 -1
============================================
- Hits 1384 1381 -3
+ Misses 504 502 -2
- Partials 84 85 +1
☔ View full report in Codecov by Sentry. |
RoeReRe
approved these changes
Oct 26, 2023
|
ps didnt know need me do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the check to move prescriptions was only done if it is a listCompleted command, changed it such that it checks after every command so if a user adds a prescription that has an end date that is already past, it goes into the completed list right away.