Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test cases for #253

Merged
merged 2 commits into from
Nov 10, 2023

Conversation

Carlintyj
Copy link
Collaborator

ThemeCommand, ThemeCommandParser, CourseUtil and Course

@Carlintyj Carlintyj added this to the v1.4 milestone Nov 9, 2023
@Carlintyj Carlintyj self-assigned this Nov 9, 2023
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #253 (0942d20) into master (9e02455) will increase coverage by 0.24%.
The diff coverage is 83.33%.

@@             Coverage Diff              @@
##             master     #253      +/-   ##
============================================
+ Coverage     76.27%   76.52%   +0.24%     
- Complexity      668      675       +7     
============================================
  Files           101      101              
  Lines          2082     2087       +5     
  Branches        227      229       +2     
============================================
+ Hits           1588     1597       +9     
+ Misses          446      441       -5     
- Partials         48       49       +1     
Files Coverage Δ
...seedu/address/logic/parser/ThemeCommandParser.java 100.00% <100.00%> (+18.75%) ⬆️
...ava/seedu/address/logic/commands/ThemeCommand.java 83.33% <85.71%> (-16.67%) ⬇️
...main/java/seedu/address/model/util/CourseUtil.java 83.33% <0.00%> (-7.58%) ⬇️

... and 1 file with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@leontan2 leontan2 self-requested a review November 10, 2023 08:58
Copy link
Collaborator

@leontan2 leontan2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Carlintyj Carlintyj merged commit 11ec38b into AY2324S1-CS2103T-T17-4:master Nov 10, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants