Add ImportCommand #126
Merged
Add ImportCommand #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for shiny-daffodil-45f25f ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
@@ Coverage Diff @@
## master #126 +/- ##
============================================
- Coverage 69.78% 66.35% -3.43%
- Complexity 559 560 +1
============================================
Files 89 93 +4
Lines 2002 2107 +105
Branches 216 235 +19
============================================
+ Hits 1397 1398 +1
- Misses 534 637 +103
- Partials 71 72 +1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
# Conflicts: # src/main/java/seedu/staffsnap/logic/commands/AddInterviewCommand.java
CelestineTan03
approved these changes
Oct 28, 2023
There was a problem hiding this comment.
Amazing work adding the import command! 🥇 I like how you provided a sample csv file applicants.csv for users to import 😄
Perhaps can include the format of the csv file to be imported into the ug, such as:
- including the header row (since the parser currently skips the first row in the csv file)
- adding applicant details in the correct order
name,phone,email,position(since the details of an applicant is currently extracted in that order, and any other order would result in an error) 😊
| */ | ||
| model.updateFilteredApplicantList(PREDICATE_HIDE_ALL_APPLICANTS); | ||
| model.updateFilteredApplicantList(PREDICATE_SHOW_ALL_APPLICANTS); | ||
| model.refreshApplicantList(); |
| + "already in Staff-Snap: %s"; | ||
| public static final String MESSAGE_CSV_CONTAINS_DUPLICATE = "The csv file contains duplicate applicants: %s"; | ||
| public static final String MESSAGE_FILE_NOT_FOUND = "File not found: %s"; | ||
| public static final String FILENAME_VALIDATION_REGEX = "[-_. A-Za-z0-9]+\\.csv"; |
| @@ -14,8 +14,7 @@ | |||
| */ | |||
| public class Interview implements Comparable<Interview> { | |||
|
|
|||
| public static final String MESSAGE_CONSTRAINTS = "Interview types should be alphanumeric"; | |||
| public static final String VALIDATION_REGEX = "\\p{Alnum}+"; | |||
| public static final String MESSAGE_CONSTRAINTS = "Interview types should not be empty"; | |||
There was a problem hiding this comment.
I agree that a non-empty interview type is a better constraint 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #96