Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Match feature #108

Merged
merged 6 commits into from
Oct 30, 2023
Merged

add Match feature #108

merged 6 commits into from
Oct 30, 2023

Conversation

Chrainx
Copy link

@Chrainx Chrainx commented Oct 27, 2023

No description provided.

@Chrainx Chrainx added type.Task Something that needs to be done, but not a story, bug, or an epic. e.g. Move testing code into a new priority.High Must do labels Oct 27, 2023
@Chrainx Chrainx added this to the v1.3 milestone Oct 27, 2023
@Chrainx Chrainx requested a review from saraozn October 27, 2023 18:23
@Chrainx Chrainx self-assigned this Oct 27, 2023
@Chrainx Chrainx linked an issue Oct 27, 2023 that may be closed by this pull request
Add Match Feature #109
Closed
@codecov
Copy link

codecov bot commented Oct 27, 2023 •
edited
Loading

Codecov Report

Attention: 53 lines in your changes are missing coverage. Please review.

Files Coverage Δ
src/main/java/seedu/address/logic/Messages.java 92.59% <ø> (ø)
...dress/logic/parser/MatchCustomerCommandParser.java 100.00% <100.00%> (ø)
...dress/logic/parser/MatchPropertyCommandParser.java 100.00% <100.00%> (ø)
src/main/java/seedu/address/model/Model.java 100.00% <ø> (ø)
...main/java/seedu/address/model/customer/Budget.java 94.11% <100.00%> (+0.36%) ⬆️
...in/java/seedu/address/model/property/Property.java 97.22% <100.00%> (ø)
...ava/seedu/address/storage/JsonAdaptedProperty.java 97.91% <100.00%> (+97.91%) ⬆️
.../main/java/seedu/address/model/property/Price.java 88.23% <0.00%> (-5.52%) ⬇️
src/main/java/seedu/address/ui/PropertyCard.java 0.00% <0.00%> (ø)
.../seedu/address/logic/parser/AddressBookParser.java 81.48% <0.00%> (-6.52%) ⬇️
... and 5 more

📢 Thoughts on this report? Let us know!.

saraozn
saraozn approved these changes Oct 30, 2023
View reviewed changes
Copy link

@saraozn saraozn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes for header comments, otherwise LGTM! :)

src/main/java/seedu/address/logic/commands/MatchCustomerCommand.java Outdated
private Index targetIndex;

/**
* Creates an MatchCustomerCommand to get all the specified {@code Property}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Creates an MatchCustomerCommand to get all the specified {@code Property}
* Creates a MatchCustomerCommand to get all the specified {@code Property}

src/main/java/seedu/address/logic/commands/MatchPropertyCommand.java Outdated
private Index targetIndex;

/**
* Creates an MatchPropertyCommand to get all the specified {@code Customer}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Creates an MatchPropertyCommand to get all the specified {@code Customer}
* Creates a MatchPropertyCommand to get all the specified {@code Customer}

src/main/java/seedu/address/model/property/SamePropertyPredicate.java Outdated
import seedu.address.commons.util.ToStringBuilder;

/**
* Tests that a {@code Customer} is same with the given customer.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be Property?

@Chrainx Chrainx merged commit 8fe5eeb into AY2324S1-CS2103T-W11-2:master Oct 30, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saraozn saraozn saraozn approved these changes

Assignees

@Chrainx Chrainx

Labels
priority.High Must do type.Task Something that needs to be done, but not a story, bug, or an epic. e.g. Move testing code into a new
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.

Add Match Feature
2 participants
@Chrainx @saraozn