Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DG changes #269

Merged
Merged

Conversation

kristayeo
Copy link

Updated UI component (image needs to be updated, otherwise, it's completed)

Added click to view friend's timetable feature

  • probably needs diagram/image
  • not sure if design considerations section is needed since its q straightforward and ensuring that the selected friend display profile is always updated doesn't have anything to consider since its the only possible solution with the immutability of person objects

@kristayeo kristayeo added this to the v1.4 milestone Nov 9, 2023
@kristayeo kristayeo self-assigned this Nov 9, 2023
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #269 (374f59b) into master (d628c21) will decrease coverage by 0.03%.
Report is 9 commits behind head on master.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #269      +/-   ##
============================================
- Coverage     75.65%   75.63%   -0.03%     
  Complexity      951      951              
============================================
  Files           111      111              
  Lines          3011     3012       +1     
  Branches        351      351              
============================================
  Hits           2278     2278              
- Misses          647      648       +1     
  Partials         86       86              

see 4 files with indirect coverage changes

Copy link

@owenyeo owenyeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

* The user clicks on the cell within the `ListView` of the friend list.
* The `onMouseClicked` event is triggered upon the user's click.
* `PersonListPanel.PersonListViewCell#updateItem()` handles this `MouseEvent` object:
* It checks if the event is a single click.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@owenyeo owenyeo merged commit 0a23c80 into AY2324S1-CS2103T-W12-4:master Nov 10, 2023
4 of 5 checks passed
@kristayeo kristayeo added the documentation Improvements or additions to documentation label Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants