Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove text truncation for list_modules #135

Merged
merged 2 commits into from
Apr 15, 2024
Merged

Conversation

taufiq
Copy link

@taufiq taufiq commented Apr 14, 2024

Fixes #136

When calling list_modues m/.., the module description texts are truncated.

image

This PR removes the truncation of 80 char that was set.

image

Key information are being truncated when left to display only up-to 80 characters for the descriptions of the mods.
Long texts are wrapped so it all fits within the width of the result display so users only need to scroll vertically and not horizontally
@taufiq taufiq requested a review from a team April 14, 2024 09:32
Copy link

codecov bot commented Apr 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 64.35%. Comparing base (1a2ecb6) to head (07d3f4f).

Files Patch % Lines
...ress/logic/commands/module/ListModulesCommand.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master     #135   +/-   ##
=========================================
  Coverage     64.35%   64.35%           
  Complexity      508      508           
=========================================
  Files            98       98           
  Lines          2003     2003           
  Branches        208      208           
=========================================
  Hits           1289     1289           
  Misses          630      630           
  Partials         84       84           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@blaukc blaukc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. this is a bug fix

@blaukc blaukc merged commit 9e35ae9 into master Apr 15, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

text truncated in list_modules
2 participants