Add data storage and retrieval functionality of transactions #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
March 20, 2024 15:22
# Conflicts: # src/main/java/budgetbuddy/BudgetBuddy.java
|
Please resolve merge conflict! Thank you! |
vibes-863
reviewed
Mar 20, 2024
vibes-863
reviewed
Mar 20, 2024
| f.createNewFile(); | ||
| } | ||
|
|
||
| assert f.exists() : "File does not exist"; |
There was a problem hiding this comment.
Nice job of extracting the code into multiple methods!
Vavinan
reviewed
Mar 20, 2024
| String[] transactionInfo = s.split(" ,"); | ||
|
|
||
| assert transactionInfo.length == 5 : "Invalid transaction information format"; | ||
| assert transactionInfo[2].equals("Income") || transactionInfo[2].equals("Expense") : "Invalid transaction type"; |
There was a problem hiding this comment.
Nice work on adding assertions at appropriate places
| case "Income": | ||
| return new Income(transactionInfo[0], Double.parseDouble(transactionInfo[4]), | ||
| transactionInfo[1], transactionInfo[3], account); | ||
| case "Expense": |
There was a problem hiding this comment.
Consider adding constants for "Expense" and "Income"
Vavinan
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.