Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build-storybook / Percy CI is failing with "JavaScript heap out of memory" #1980

Closed
sleidig opened this issue Aug 21, 2023 · 5 comments · Fixed by #1982
Closed

build-storybook / Percy CI is failing with "JavaScript heap out of memory" #1980

sleidig opened this issue Aug 21, 2023 · 5 comments · Fixed by #1982
Assignees
Labels
released managed by CI (semantic-release) Type: CI & Testing related to devOps, continuous integration and automatic testing

Comments

@sleidig
Copy link
Member

sleidig commented Aug 21, 2023

See CI: e.g. https://github.com/Aam-Digital/ndb-core/actions/runs/5923239290/job/16058498260

While npm run storybook seems to run okay on local machines, our CI job to do visual regression testing using Storybook is failing at the step of building storybook statically:
npm run build-storybook (which uses ng run ndb-core:build-storybook, i.e. "builder": "@storybook/angular:build-storybook") exits with

FATAL ERROR: Reached heap limit Allocation failed - JavaScript heap out of memory

@sleidig
Copy link
Member Author

sleidig commented Aug 21, 2023

This is probably related to this: storybookjs/storybook#6408

setting storyStoreV7: false didn't resolve it for me, however.
after cleaning up a bit, disabling storyStoreV7 indeed does get the build to completion ...

@sleidig
Copy link
Member Author

sleidig commented Aug 21, 2023

while the build-storybook runs now, Percy closes the browser and stops after only 2 stories. Somehow after one of the most simple components (Features/Attendance/Components/ActivityCard) decides to stop

@sleidig
Copy link
Member Author

sleidig commented Aug 22, 2023

The build storybook seems to behave a bit different from the hot-reload "npm run storybook". Now I see an error with ɵɵinvalidFactoryDep

storybookjs/storybook#23534
has a workaround (set "enableProdMode": false) that seems to help

@sleidig sleidig self-assigned this Aug 22, 2023
@sleidig sleidig added the Type: CI & Testing related to devOps, continuous integration and automatic testing label Aug 22, 2023
sleidig added a commit that referenced this issue Aug 24, 2023
closes #1980

Co-authored-by: Simon <simon@aam-digital.com>
@aam-digital-ci
Copy link
Collaborator

🎉 This issue has been resolved in version 3.24.0-master.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci
Copy link
Collaborator

🎉 This issue has been resolved in version 3.24.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released managed by CI (semantic-release) label Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released managed by CI (semantic-release) Type: CI & Testing related to devOps, continuous integration and automatic testing
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants