Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select & Link existing entity from related-entities-tables #2383

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sleidig
Copy link
Member

@sleidig sleidig commented May 10, 2024

closes: #2201

--> to test: go to school details > tab "activities": select & link existing activity to the school with the new system

  • component to offer a UI for seeing suggested existing entities and selecting one (as an alternative to fill a form and create a new entity)
  • stub service to load suggested existing entities
  • removed specific EditTextWithAutocomplete and use this more generic approach instead (which is based on that previous code)

remaining issues

  • after updating / linking an existing record, the app shows "conflicting update" warning
  • tests have some broken setup code not correctly adapted from the previous component yet

further improvements:

  • logic to filter / load only similar entities (e.g. matching by name or other fields filled in the form); currently the selection of an existing record is just a normal entity-select, which may be sufficient for a first iteration however.

Copy link

Deployed to https://pr-2383.aam-digital.net/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding existing records from a related entities table (generalize EditTextWithAutocomplete)
2 participants