Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: simplify main #585

Merged
merged 3 commits into from
Jun 21, 2024
Merged

chore: simplify main #585

merged 3 commits into from
Jun 21, 2024

Conversation

MartinBernstorff
Copy link
Collaborator

  • Removes support for lazyframes
  • Simplifies the main file

Copy link

codspeed-hq bot commented Jun 21, 2024

CodSpeed Performance Report

Merging #585 will improve performances by 13.34%

Comparing mbern_simplify_main (eab8961) with main (7377287)

Summary

⚡ 7 improvements

Benchmarks breakdown

Benchmark main mbern_simplify_main Change
test_bench[aggregations=['max', 'mean']] 99.1 ms 51.3 ms +93.04%
test_bench[n_features=2.0x] 142.3 ms 94.1 ms +51.29%
test_bench[n_lookbehinds=2.0x] 142.4 ms 93.1 ms +52.9%
test_bench[n_lookbehinds=4.0x] 229.4 ms 180.5 ms +27.11%
test_bench[n_lookbehinds=8.0x] 402.1 ms 354.8 ms +13.34%
test_bench[n_pred_times=2.0x] 190.4 ms 95.3 ms +99.84%
test_bench[x] 99.1 ms 51.4 ms +92.76%

@MartinBernstorff MartinBernstorff merged commit 51d0c84 into main Jun 21, 2024
12 of 13 checks passed
@MartinBernstorff MartinBernstorff deleted the mbern_simplify_main branch June 21, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant