Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sorbet-unwrap command #2

Merged
merged 2 commits into from
Mar 11, 2020

Conversation

paracycle
Copy link
Collaborator

Debugging code with Sorbet signatures is really hard due to Sorbet method wrapping. When stepping through code, one always hits sorbet-runtime locations, which is distracting and confusing.

This PR adds a sorbet-unwrap command to remove all Sorbet method wrappers from methods. This is again done by reaching into sorbet-runtime private classes and instance variables, but the internals of this part of the sorbet-runtime codebase seems to be fairly stable.

The README is updated with more explanation of what the gem does and how it works.

@paracycle paracycle requested a review from AaronC81 March 11, 2020 14:17
@AaronC81
Copy link
Owner

LGTM, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants