Read local RBI files when parsing #169
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update adds the local
sorbetdirectory tosord's list. Most gems don't have actualrbidirectories in them - instead a lot of them depend onsorbet-typed. Usingtapiocawill dump a bunch of RBI files into a localsorbetdirectory, whichsordcan then read and use as types inside type declarations.This does take a bit of time (the default is to actually generate types for every single gem that's included, which is likely overkill since very few of them would be directly referenced in the project code). Not sure if we want to print out some kind of message when we parse this directory indicating that the user might want to delete some of those auto-generated files to speed up the process.