Possible to assign multiple filters with the same name

[tfausak]

It's possible to define an interaction with any number of filters sharing a name.

class Interaction < ActiveInteraction::Base
  boolean :thing
  boolean :thing, default: nil
  boolean :thing, default: false
  def execute; inputs end
end

This usually doesn't matter too much because the last one will take precedence.

Interaction.run!
# => {:thing=>false}

However, they're all still there.

Interaction.filters.instance_variable_get(:@filters)
# => [#<ActiveInteraction::BooleanFilter:0x... @name=:thing, @options={}, ...>, 
#     #<ActiveInteraction::BooleanFilter:0x... @name=:thing, @options={:default=>nil}, ...>, 
#     #<ActiveInteraction::BooleanFilter:0x... @name=:thing, @options={:default=>false}, ...>]

The way I see it, we have a couple options for what to do when someone redefines an existing filter:

• Merge it into the existing filter.
• Replace the existing filter.
• Raise an error.
• Generate a warning.

[tfausak]

I discovered this because of the workaround for #104. I imported filters from two separate interactions and they happened to overlap. It ended up causing a hard-to-find bug.

[tfausak]

After talking it over in person, I think we should replace the existing filter. That way including filters will behave like including modules — the last one wins.