Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Filters with Hash #111

Closed
tfausak opened this issue Jan 16, 2014 · 0 comments
Closed

Replace Filters with Hash #111

tfausak opened this issue Jan 16, 2014 · 0 comments
Assignees
@tfausak
Labels
enhancement
Milestone
v1.0.0

Comments

@tfausak
Copy link
Collaborator

tfausak commented Jan 16, 2014

After the changes to Filters introduced by #103 (and, to a lesser extent, #106), it makes sense to replace Filters with a Hash object. We simply don't get anything out of having a bespoke collection object for the filters.

This would have to be a breaking change because filters.each will have to be replaced by filters.values.each.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tfausak tfausak

Labels
enhancement
Projects
None yet
Milestone
v1.0.0
Development

No branches or pull requests
1 participant
@tfausak