Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Arrays for parentOrigin parameter #2

Merged
merged 1 commit into from
Mar 29, 2017
Merged

Support Arrays for parentOrigin parameter #2

merged 1 commit into from
Mar 29, 2017

Conversation

Gomah
Copy link
Contributor

@Gomah Gomah commented Mar 27, 2017

Thanks for actively maintaining this repository 👍

@Gomah
Copy link
Contributor Author

Gomah commented Mar 27, 2017

Not sure about the hijack scenario as we are checking the defined parentOrigin Array/string against event.origin ?

https://jsfiddle.net/ymqr66ac/

@Aaronius
Copy link
Owner

I got it backward. http://example.com could load in and communicate with a view that is expecting to only communicate with http://example.company.

https://jsfiddle.net/mt6nv0hd/1/

Thanks for this PR. I'll fix it up and get it merged.

@Aaronius Aaronius merged commit 3d3a9b0 into Aaronius:master Mar 29, 2017
@Aaronius
Copy link
Owner

@Gomah I've published this as 2.5.0. Thank you for the contribution!

@Gomah
Copy link
Contributor Author

Gomah commented Mar 29, 2017

Great, thanks @Aaronius !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants