Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored a ton of files. #55

Merged
merged 1 commit into from
Feb 8, 2022

Commits on Feb 6, 2022

  1. Removed unnecessary files (i. e. Storyboard, AppDelegate)

    - Moved building the status bar in `NativeYoutubeApp.swift`
    - Created a Settings view so that we don't have to use `createNewWindow`.
    - Cleaned up views and reorganized PreferencesView.
    - Remove redundant environmentObject
    - Moved `SettingsView.swift`, now known as `YoutubePreferencesView.swift`, to `Setting` Scene.
    - Created an `AppStateViewModel.swift` to share with other views about its state so we can isolate `SettingsViewModel`, which is now `YoutubePreferenceViewModel`.
    - Moved specific view states from ObservableObject to the view
    - Refactored `PlayListModel.swift` and `SearchModel.swift` to `VideoModel.swift`
    - SearchRequest and PlaylistRequest now fetch only videos with the data it requires to play videos..
    - Refactored `PlayListRowView.swift` and `SearchRowView.swift` as one since they both show only videos as of now.
    - Improve showing ui when searching or loading videos
    - Improve button appearance for search button
    - Fixed issue when running shell command would block main thread.
    ErrorErrorError committed Feb 6, 2022
    Configuration menu
    Copy the full SHA
    bf66928 View commit details
    Browse the repository at this point in the history