Added URLSchemes #59
Merged
Added URLSchemes #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ideo-id}` then the app will open a new window plater and play the video. - Moved `YoutubePlayerViewModel` to `NativeYoutubeApp.swift` since it is needed if a user uses a url to launch app - Removed `currentPlayer` from `YoutubePlayerViewModel` since it was unnecessary.
That looks very familiar... |
|
Also awesome it works pretty well! Great work 🙌🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests adds the feature from #58. The way you can launch a window using a url scheme would be by specifying the video id in
{video-id}onnativeyoutube://video-id/{video-id}.An example to try:
nativeyoutube://video-id/dQw4w9WgXcQ:)