Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lexer testing #75

Merged
merged 8 commits into from Oct 14, 2021
Merged

Lexer testing #75

merged 8 commits into from Oct 14, 2021

Conversation

CodeScratcher
Copy link

I think this testing for the lexer should be good!

@pep8speaks
Copy link

pep8speaks commented Nov 28, 2020 •
edited

Hello @CodeScratcher! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 18:80: E501 line too long (82 > 79 characters)
Line 45:1: E302 expected 2 blank lines, found 0
Line 61:1: E122 continuation line missing indentation or outdented
Line 65:1: E122 continuation line missing indentation or outdented
Line 69:1: E122 continuation line missing indentation or outdented
Line 73:1: E122 continuation line missing indentation or outdented

Comment last updated at 2020-11-28 14:20:56 UTC

@lgtm-com
Copy link

lgtm-com bot commented Nov 28, 2020

This pull request introduces 2 alerts when merging 78c595d into 43de215 - view on LGTM.com

new alerts:

  • 2 for Unused import

Abdur-rahmaanJ
Abdur-rahmaanJ reviewed Nov 29, 2020
View reviewed changes
greenberry/greenberry_lex_test.py
if not (a[0].startswith("__") and a[0].endswith("__"))
]
]
]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though a work of art, those comprehensions will give me nightmares while reading the source again. Could you use normal loops? Thank You!

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thisusernameisavailable

@Abdur-rahmaanJ
Copy link
Owner

@CodeScratcher merging

@Abdur-rahmaanJ Abdur-rahmaanJ merged commit 5c71fd6 into Abdur-rahmaanJ:master Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Abdur-rahmaanJ Abdur-rahmaanJ Abdur-rahmaanJ left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@CodeScratcher @pep8speaks @Abdur-rahmaanJ @thisusernameisavailable