Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added shootingstar #61

Merged
merged 2 commits into from Nov 22, 2023
Merged

added shootingstar #61

merged 2 commits into from Nov 22, 2023

Conversation

Jagathi-kota
Copy link
Contributor

I have added shootingstar.py to the hooman folder.

@Jagathi-kota Jagathi-kota mentioned this pull request Nov 22, 2023
Open
TheBigKahuna353
TheBigKahuna353 requested changes Nov 22, 2023
View reviewed changes
Copy link
Collaborator

@TheBigKahuna353 TheBigKahuna353 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, could you add a fps limiter, which can be achieved using hapi.clock.tick(fps)

also, are the stars supposed to reset back to 0,0?

@Jagathi-kota
Copy link
Contributor Author

Jagathi-kota commented Nov 22, 2023 •
edited

I have changed the code according to the provided requirements can you please review and merge it.

Thanks,
Jagathi

@Abdur-rahmaanJ Abdur-rahmaanJ merged commit 7b528b9 into Abdur-rahmaanJ:master Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheBigKahuna353 TheBigKahuna353 TheBigKahuna353 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Jagathi-kota @TheBigKahuna353 @Abdur-rahmaanJ