Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change abjad.LilyPondLiteral default site from "opening" to "before" #1529

Closed
trevorbaca opened this issue Apr 8, 2023 · 0 comments · Fixed by #1530
Closed

Change abjad.LilyPondLiteral default site from "opening" to "before" #1529

trevorbaca opened this issue Apr 8, 2023 · 0 comments · Fixed by #1530
Assignees
@trevorbaca
Labels
refactor
Milestone
3.17

Comments

@trevorbaca
Copy link
Member

Abjad leaves should only format "before" and "after" sites. (Though Abjad containers can format "before", "after", "opening" and "closing" sites.) Because abjad.LilyPondLiteral objects almost always get attached to leaves (instead of containers), it makes sense to change the default format site of LilyPond literals from (container-like) "opening" to (leaf-like) "before".
@trevorbaca trevorbaca added this to the 3.17 milestone Apr 8, 2023
@trevorbaca trevorbaca self-assigned this Apr 8, 2023
trevorbaca added a commit that referenced this issue Apr 8, 2023
@trevorbaca
Changed abjad.LilyPondLiteral default site from "opening" to "before."
2083f09 
Closes #1529.
trevorbaca added a commit that referenced this issue Apr 8, 2023
@trevorbaca
Changed abjad.LilyPondLiteral default site from "opening" to "before."
a8a72d9 
Closes #1529.
@trevorbaca trevorbaca mentioned this issue Apr 8, 2023
Merged
trevorbaca added a commit that referenced this issue Apr 8, 2023
@trevorbaca
Changed abjad.LilyPondLiteral default site from "opening" to "before." (
d818d3e 
#1530)

Closes #1529.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trevorbaca trevorbaca

Labels
refactor
Projects
None yet
Milestone
3.17
Development

Successfully merging a pull request may close this issue.

Changed abjad.LilyPondLiteral default site from "opening" to "before." Abjad/abjad
1 participant
@trevorbaca