Extend find-slots-inconsistencies

[trevorbaca]

The script is already very useful.

We need to extend it to demand that the following condition hold for all classes systemwide: if a baseclass defines __slots__ then all concrete inheritors need to also implement __slots__.

What happens when this condition fails to hold?

Nothing for months on end. But then when it becomes necessary to implement __getstate__(), __setstate__() or __copy__() then the concrete inheritors almost always fail the parameterized copy and deepcopy tests.

The fix is straightforward: make sure concrete inheritors implement __slots__.

[trevorbaca]

I think this is still valid in June 2017:

16:15 $ find-slots-inconsistencies 

No bad slots relationships found.
56 children without own __slots__ definition found:
	abctools.AbjadObject -> part.PartCantusScoreTemplate
	abctools.AbjadObject -> documentationtools.DocumentationManager
	abctools.AbjadObject -> instrumenttools.Performer
	abctools.AbjadObject -> instrumenttools.WoodwindFingering
	abctools.AbjadObject -> lilypondfiletools.Block
	abctools.AbjadObject -> lilypondnametools.LilyPondNameManager
	abctools.AbjadObject -> lilypondparsertools.GuileProxy
	abctools.AbjadObject -> lilypondparsertools.LilyPondEvent
	abctools.AbjadObject -> lilypondparsertools.LilyPondGrammarGenerator
	abctools.AbjadObject -> lilypondparsertools.LilyPondLexicalDefinition
	abctools.AbjadObject -> lilypondparsertools.LilyPondSyntacticalDefinition
	abctools.AbjadObject -> metertools.MeterManager
	abctools.AbjadObject -> quantizationtools.AttackPointOptimizer
	abctools.AbjadObject -> quantizationtools.Heuristic
	abctools.AbjadObject -> quantizationtools.JobHandler
	abctools.AbjadObject -> quantizationtools.ParallelJobHandlerWorker
	abctools.AbjadObject -> quantizationtools.Quantizer
	abctools.AbjadObject -> systemtools.BenchmarkScoreMaker
	abctools.AbjadObject -> systemtools.IOManager
	abctools.AbjadObject -> systemtools.ImportManager
	abctools.AbjadObject -> systemtools.LilyPondFormatManager
	abctools.AbjadObject -> systemtools.TestManager
	abctools.AbjadObject -> systemtools.UpdateManager
	abctools.AbjadObject -> systemtools.WellformednessManager
	abctools.AbjadObject -> templatetools.GroupedRhythmicStavesScoreTemplate
	abctools.AbjadObject -> templatetools.GroupedStavesScoreTemplate
	abctools.AbjadObject -> templatetools.StringQuartetScoreTemplate
	abctools.AbjadObject -> templatetools.TwoStaffPianoScoreTemplate
	abctools.AbjadValueObject -> pitchtools.RegistrationComponent
	abctools.AbjadValueObject -> rhythmmakertools.GalleryMaker
	abctools.ContextManager -> systemtools.NullContextManager
	abctools.ContextManager -> systemtools.ProgressIndicator
	abctools.ContextManager -> systemtools.RedirectedStreams
	commandlinetools.CommandlineScript -> abjadbooktools.AbjadBookScript
	commandlinetools.CommandlineScript -> commandlinetools.AbjDevScript
	commandlinetools.CommandlineScript -> commandlinetools.BuildApiScript
	commandlinetools.CommandlineScript -> commandlinetools.CheckClassSections
	commandlinetools.CommandlineScript -> commandlinetools.CleanScript
	commandlinetools.CommandlineScript -> commandlinetools.DoctestScript
	commandlinetools.CommandlineScript -> commandlinetools.ReplaceScript
	commandlinetools.CommandlineScript -> commandlinetools.ScorePackageScript
	commandlinetools.CommandlineScript -> commandlinetools.StatsScript
	datastructuretools.TreeContainer -> documentationtools.ReSTDirective
	datastructuretools.TreeContainer -> documentationtools.ReSTDocument
	datastructuretools.TreeNode -> documentationtools.ReSTAutosummaryItem
	datastructuretools.TreeNode -> documentationtools.ReSTHeading
	datastructuretools.TreeNode -> documentationtools.ReSTHorizontalRule
	datastructuretools.TreeNode -> documentationtools.ReSTParagraph
	datastructuretools.TreeNode -> documentationtools.ReSTTOCItem
	lilypondparsertools.Music -> lilypondparsertools.SimultaneousMusic
	pitchtools.Vector -> pitchtools.IntervalClassVector
	pitchtools.Vector -> pitchtools.IntervalVector
	pitchtools.Vector -> pitchtools.PitchClassVector
	pitchtools.Vector -> pitchtools.PitchVector
	quantizationtools.GraceHandler -> quantizationtools.CollapsingGraceHandler
	quantizationtools.GraceHandler -> quantizationtools.DiscardingGraceHandler

Note that it's possible that the secondary output (about 56 child classes without own slots implementation) may be answering the request in this issue. In which case empty __slots__ = () definitions should be added to all 56 classes and this issue can be closed.

[trevorbaca]

Done in 2.21.