-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make _storage_format_specification a method. #641
Labels
Comments
In June 2017 There are what look to be ancient (and probably unused) references to
Will leave issue open until |
Done in 2.21. |
trevorbaca
added a commit
that referenced
this issue
Jul 31, 2017
trevorbaca
added a commit
that referenced
this issue
Jul 31, 2017
trevorbaca
added a commit
that referenced
this issue
Jul 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There are currently two format-related properties on AbjadObject subclasses:
_storage_format_specification
_repr_specification
When
hasattr(..., '_storage_format_specification')
is called on an AbjadObject subclass instance, the property is evaluated. Then, typically, the property is accessed. This effectively totals a double evaluation of configuring and instantiating a StorageFormatSpecification object.We should convert all such properties to
_get_...()
methods to avoid these double evaluations triggered byhasattr()
.The text was updated successfully, but these errors were encountered: