Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate rhythmmakertools.silence*(), sustain*() to SilenceMask, SustainMask static methods #842

Closed
trevorbaca opened this issue Jul 6, 2017 · 1 comment
Closed

Migrate rhythmmakertools.silence*(), sustain*() to SilenceMask, SustainMask static methods #842

trevorbaca opened this issue Jul 6, 2017 · 1 comment
Assignees
@trevorbaca
Labels
refactor

Comments

@trevorbaca
Copy link
Member

Now:

rhythmmakertools.silence()
rhythmmakertools.silence_all()
rhythmmakertools.silence_every()
rhythmmakertools.silence_except()
rhythmmakertools.silence_first()
rhythmmakertools.silence_last()

rhythmmakertools.sustain()
rhythmmakertools.sustain_all()
rhythmmakertools.sustain_every()
rhythmmakertools.sustain_first()
rhythmmakertools.sustain_last()

Better:

SilenceMask.silence()
SilenceMask.silence_all()
SilenceMask.silence_every()
SilenceMask.silence_except()
SilenceMask.silence_first()
SilenceMask.silence_last()

SustainMask.sustain()
SustainMask.sustain_all()
SustainMask.sustain_every()
SustainMask.sustain_first()
SustainMask.sustain_last()

Static methods can then be imported into rhythmmakertools namespace to preserve existing user interface.
@trevorbaca trevorbaca self-assigned this Jul 6, 2017
trevorbaca added a commit that referenced this issue Jul 9, 2017
@trevorbaca
(#842) Migrated rhythmmakertools.silence*(), sustain*() to static met…
a595e42 
…hods.

This closes #842.
@trevorbaca
Copy link
Member Author

Done in 2.21.

trevorbaca added a commit that referenced this issue Jul 31, 2017
@trevorbaca
(#842) Migrated rhythmmakertools.silence*(), sustain*() to static met…
0b41b14 
…hods.

This closes #842.
trevorbaca added a commit that referenced this issue Jul 31, 2017
@trevorbaca
(#842) Migrated rhythmmakertools.silence*(), sustain*() to static met…
40ae386 
…hods.

This closes #842.
trevorbaca added a commit that referenced this issue Jul 31, 2017
@trevorbaca
(#842) Migrated rhythmmakertools.silence*(), sustain*() to static met…
d65ef7c 
…hods.

This closes #842.
trevorbaca added a commit that referenced this issue Jul 31, 2017
@trevorbaca
(#842) Migrated rhythmmakertools.silence*(), sustain*() to static met…
1e9dd12 
…hods.

This closes #842.
trevorbaca added a commit that referenced this issue Jul 31, 2017
@trevorbaca
(#842) Migrated rhythmmakertools.silence*(), sustain*() to static met…
28e3a9d 
…hods.

This closes #842.
trevorbaca added a commit that referenced this issue Jul 31, 2017
@trevorbaca
(#842) Migrated rhythmmakertools.silence*(), sustain*() to static met…
365b5d0 
…hods.

This closes #842.
trevorbaca added a commit that referenced this issue Jul 31, 2017
@trevorbaca
(#842) Migrated rhythmmakertools.silence*(), sustain*() to static met…
4257b67 
…hods.

This closes #842.
trevorbaca added a commit that referenced this issue Jul 31, 2017
@trevorbaca
(#842) Migrated rhythmmakertools.silence*(), sustain*() to static met…
7195b53 
…hods.

This closes #842.
trevorbaca added a commit that referenced this issue Jul 31, 2017
@trevorbaca
(#842) Migrated rhythmmakertools.silence*(), sustain*() to static met…
f3d74e1 
…hods.

This closes #842.
trevorbaca added a commit that referenced this issue Jul 31, 2017
@trevorbaca
(closes #842) Added SilenceMask.silence*() methods.
35d588f 
Added SustainMask.sustain*() methods.
trevorbaca added a commit that referenced this issue Jul 31, 2017
@trevorbaca
(closes #842) Added SilenceMask.silence*() methods.
633f5f1 
Added SustainMask.sustain*() methods.
trevorbaca added a commit that referenced this issue Jul 31, 2017
@trevorbaca
(closes #842) Added SilenceMask.silence*() methods.
b12032d 
Added SustainMask.sustain*() methods.
trevorbaca added a commit that referenced this issue Jul 31, 2017
@trevorbaca
(closes #842) Added SilenceMask.silence*() methods.
8ed0d8d 
Added SustainMask.sustain*() methods.
trevorbaca added a commit that referenced this issue Jul 31, 2017
@trevorbaca
(closes #842) Added SilenceMask.silence*() methods.
ef8a010 
Added SustainMask.sustain*() methods.
trevorbaca added a commit that referenced this issue Jul 31, 2017
@trevorbaca
(closes #842) Added SilenceMask.silence*() methods.
2863724 
Added SustainMask.sustain*() methods.
trevorbaca added a commit that referenced this issue Jul 31, 2017
@trevorbaca
(closes #842) Added SilenceMask.silence*() methods.
2748d44 
Added SustainMask.sustain*() methods.
trevorbaca added a commit that referenced this issue Jul 31, 2017
@trevorbaca
(closes #842) Added SilenceMask.silence*() methods.
63ece7c 
Added SustainMask.sustain*() methods.
trevorbaca added a commit that referenced this issue Jul 31, 2017
@trevorbaca
(closes #842) Added SilenceMask.silence*() methods.
312858e 
Added SustainMask.sustain*() methods.
trevorbaca added a commit that referenced this issue Jul 31, 2017
@trevorbaca
(closes #842) Added SilenceMask.silence*() methods.
2c7312a 
Added SustainMask.sustain*() methods.
trevorbaca added a commit that referenced this issue Jul 31, 2017
@trevorbaca
(closes #842) Added SilenceMask.silence*() methods.
7833e73 
Added SustainMask.sustain*() methods.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trevorbaca trevorbaca

Labels
refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@trevorbaca