Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaned up indicators. #1540

Merged
merged 1 commit into from Apr 17, 2023
Merged

Cleaned up indicators. #1540

merged 1 commit into from Apr 17, 2023

Conversation

trevorbaca
Copy link
Member

CHANGED. The "site" argument to abjad.LilyPondLiteral is now keyword-only:

OLD: abjad.LilyPondLiteral(..., site)
NEW: abjad.LilyPondLiteral(..., *, site="before")

CHANGED. Made abjad.MetricModulation into frozen dataclass.

CHANGED. Renamed abjad.StaffChange parameter:

OLD: abjad.StaffChange.staff
NEW: abjad.StaffChange.staff_name

REMOVED remove_ly keyword from these:

* abjad.persist.as_midi()
* abjad.persist.as_pdf()
* abjad.persist.as_png()

CHANGED. The "site" argument to abjad.LilyPondLiteral is now keyword-only:

    OLD: abjad.LilyPondLiteral(..., site)
    NEW: abjad.LilyPondLiteral(..., *, site="before")

CHANGED. Made abjad.MetricModulation into frozen dataclass.

CHANGED. Renamed abjad.StaffChange parameter:

    OLD: abjad.StaffChange.staff
    NEW: abjad.StaffChange.staff_name

REMOVED remove_ly keyword from these:

    * abjad.persist.as_midi()
    * abjad.persist.as_pdf()
    * abjad.persist.as_png()
@trevorbaca trevorbaca added this to the 3.17 milestone Apr 17, 2023
@trevorbaca trevorbaca self-assigned this Apr 17, 2023
@trevorbaca trevorbaca merged commit 0480049 into main Apr 17, 2023
0 of 2 checks passed
@trevorbaca trevorbaca deleted the trevor/indicator-cleanup branch April 17, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant