Fixed duplicated dynamics corner case. #1554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Abjad 3.18, this fails to raise an exception:
voice = abjad.Voice("c'4")
bundle = abjad.bundle(
abjad.Dynamic("p"),
abjad.Tweak(r"- \tweak color #red"),
)
abjad.attach(bundle, voice[0])
abjad.attach(abjad.Dynamic("f"), voice[0])
string = abjad.lilypond(voice)
print(string)
As of this commit, the code above now raises
abjad.PersistentIndicatorError.
Closes #1553.
ALSO:
Added to-barline = ##f to arrowed line styles.
These are Abjad's two arrowed line styles:
* abjad-dashed-line-with-arrow
* abjad-solid-line-with-arrow
Both now include ...
- \tweak to-barline ##f
... because arrow line styles should always connect right to their stop
leaf; allowing to-bareline = ##t means that arrow line styles sometimes
leave a gap before their stop leaf.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Abjad 3.18, this fails to raise an exception:
As of this commit, the code above now raises
abjad.PersistentIndicatorError.
Closes #1553.
ALSO:
Added to-barline = ##f to arrowed line styles.
These are Abjad's two arrowed line styles:
* abjad-dashed-line-with-arrow
* abjad-solid-line-with-arrow
Both now include ...
... because arrow line styles should always connect right to their stop leaf; allowing to-bareline = ##t means that arrow line styles sometimes leave a gap before their stop leaf.