Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak logs, log configuration info #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
/target
*.vim
.idea/
14 changes: 7 additions & 7 deletions src/configuration/config.rs
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,14 @@

use serde_aux::field_attributes::deserialize_number_from_string;

#[derive(serde::Deserialize, Clone)]
#[derive(serde::Deserialize, serde::Serialize, Clone, Debug)]
pub struct ApplicationConfig {
pub short_url_base: url::Url,
pub long_url_base: url::Url,
pub default_expire_in_sec: Option<u32>,
}

#[derive(serde::Deserialize, Clone)]
#[derive(serde::Deserialize, serde::Serialize, Clone, Debug)]
pub struct ServerConfig {
pub host: String,
#[serde(deserialize_with = "deserialize_number_from_string")]
Expand All @@ -32,31 +32,31 @@ pub struct ServerConfig {
pub aws: Option<AwsConfig>,
}

#[derive(serde::Deserialize, Clone)]
#[derive(serde::Deserialize, serde::Serialize, Clone, Debug)]
pub struct CertificateConfig {
pub certificate_path: String,
pub certificate_key_path: String,
}

#[derive(serde::Deserialize, Clone)]
#[derive(serde::Deserialize, serde::Serialize, Clone, Debug)]
pub struct S3Config {
pub certificate_bucket: String,
pub certificate_path: String,
pub certificate_key_path: String,
}

#[derive(serde::Deserialize, Clone)]
#[derive(serde::Deserialize, serde::Serialize, Clone, Debug)]
pub struct AwsConfig {
pub region: Option<String>,
pub s3: S3Config,
}

#[derive(serde::Deserialize, Clone)]
#[derive(serde::Deserialize, serde::Serialize, Clone, Debug)]
pub struct RedisConfig {
pub url: url::Url,
}

#[derive(serde::Deserialize, Clone)]
#[derive(serde::Deserialize, serde::Serialize, Clone, Debug)]
pub struct Config {
pub server_internal: ServerConfig,
pub server_external: ServerConfig,
Expand Down
4 changes: 2 additions & 2 deletions src/configuration/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ use ::config as configrs;

use crate::error::prelude::*;

pub fn load_config() -> SResult<config::Config> {
pub fn load_config() -> SResult<Config> {
let base_path = std::env::current_dir().expect("Failed to determine the current directory");
let configuration_directory = base_path.join("config");

Expand Down Expand Up @@ -63,7 +63,7 @@ pub fn load_config() -> SResult<config::Config> {
}
};

config.try_deserialize::<config::Config>().map_err(|err| {
config.try_deserialize::<Config>().map_err(|err| {
SError::from_msg(
SErrorType::ParsingError,
&format!("Failed to deserialize Config, error: {}", err),
Expand Down
6 changes: 2 additions & 4 deletions src/server/external/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,7 @@ pub async fn build_server_external(config: &mut Config) -> SResult<Server> {
})?
.port();

tracing::info!("Building services");
let services = web::Data::new(build_services(config).await?);

tracing::info!("Configuring external server");
let mut server = HttpServer::new(move || {
App::new()
.wrap(TracingLogger::default())
Expand All @@ -56,7 +53,7 @@ pub async fn build_server_external(config: &mut Config) -> SResult<Server> {
});

if let Some(cert_config) = &config.server_external.certs {
tracing::info!("TLS enabled");
tracing::info!("External server: TLS enabled");
let rustls_config = load_rustls_config(
&cert_config.certificate_path,
&cert_config.certificate_key_path,
Expand All @@ -67,5 +64,6 @@ pub async fn build_server_external(config: &mut Config) -> SResult<Server> {
server = server.listen(listener)?;
};

tracing::info!("External server: Starting with config: {:?}", config.server_external);
Ok(server.run())
}
8 changes: 3 additions & 5 deletions src/server/internal/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,7 @@ pub async fn build_server_internal(config: &mut Config) -> SResult<Server> {
})?
.port();

tracing::info!("Building services");
let services = web::Data::new(build_services(config).await?);

tracing::info!("Configuring internal server");
let mut server = HttpServer::new(move || {
App::new()
.wrap(TracingLogger::default())
Expand All @@ -56,16 +53,17 @@ pub async fn build_server_internal(config: &mut Config) -> SResult<Server> {
});

if let Some(cert_config) = &config.server_internal.certs {
tracing::info!("TLS enabled");
tracing::info!("Internal server: TLS enabled");
let rustls_config = load_rustls_config(
&cert_config.certificate_path,
&cert_config.certificate_key_path,
);
server = server.listen_rustls(listener, rustls_config)?;
} else {
tracing::info!("TLS disabled");
tracing::info!("Internal server: TLS disabled");
server = server.listen(listener)?;
};

tracing::info!("Internal server: Starting with config: {:?}", config.server_internal);
Ok(server.run())
}
1 change: 1 addition & 0 deletions src/service/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ pub async fn build_services(config: &Config) -> SResult<Services> {
let redis_client = Arc::new(Mutex::new(
RedisClient::connect(config.redis.url.as_str()).await?,
));
info!("Building service layer with application config: {}, redis config: {}", json!(config.application), json!(config.redis));
let service_shorten = ServiceShorten::new(redis_client, config.clone());
Ok(Services { service_shorten })
}