-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cobrix converting incorrectly number instead of string value for Hexa C4, C5 values #474
Comments
@yruslan - Can you please clarify here |
This is signed overpunch when the sign of the number is embedded into the number using an extended table. |
Thanks @yruslan , Actually we are getting 4 as output instead of null for the 0xc4. |
A couple of questions regarding the use case:
Please, take a look at this page to understand why this is happenning: https://en.wikipedia.org/wiki/Signed_overpunch |
After checking the logic once more I think I can see why this is confusing. It seems Cobrix is too permissive and allows sign overpunching for unsigned data (with PIC like '9(7)'). But sign overpunching should be available only for signed fields (PIC of 'S9(7)'). Here is the proposed change: #475 |
thanks @yruslan , I will check and let you know.. we don't have permission to check on-prem code and configuration in the current project :) |
Fix working fine, Thanks a lot @yruslan |
While reading EBCDIC file with Cobrix Library , noticed that it converts incorrectly as numbers for few Hexa value instead of null.
CopyBook:
RecordIdentifier PIC 9(1)
RecordName PIC x(10)
Sample Data:
Hex Value Cobrix Output Expected Output
f9 9 9
c4 4 null ( equivalent data -> D since it is number in copybook so it should null )
c5 5 null ( equivalent data -> E since it is number in copybook so it should null )
d6 null null
Could you please clarify why it is happening like this ?
The text was updated successfully, but these errors were encountered: