Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#38 Add scala 2.13 support #43

Merged
merged 5 commits into from
Aug 3, 2023
Merged

Conversation

yruslan
Copy link
Contributor

@yruslan yruslan commented Aug 1, 2023

Added support for Scala 2.13 by selectively compile against hofs dependencies.

  • Use hofs for Scala 2.11
  • Use Spark transform() for Scala 2.12 and Scala 2.13

@yruslan yruslan force-pushed the feature/38-add-scala-2.13-support branch from f2ae57c to 6712cec Compare August 1, 2023 07:58
@github-actions
Copy link

github-actions bot commented Aug 1, 2023

JaCoCo code coverage report - Scala 2.12.18 & Spark 3.2.4

File Coverage [83.12%] 🍏
HofsWrapper.scala 100% 🍏
NestedArrayTransformations.scala 82.9% 🍏
Total Project Coverage 86.08% 🍏

@github-actions
Copy link

github-actions bot commented Aug 1, 2023

JaCoCo code coverage report - Scala 2.11.12 & Spark 2.4.8

File Coverage [80.61%] 🍏
HofsWrapper.scala 100% 🍏
NestedArrayTransformations.scala 80.51% 🍏
Total Project Coverage 82.82% 🍏

@github-actions
Copy link

github-actions bot commented Aug 1, 2023

JaCoCo code coverage report - Scala 2.13.11 & Spark 3.4.1

File Coverage [81.95%] 🍏
HofsWrapper.scala 100% 🍏
NestedArrayTransformations.scala 81.83% 🍏
Total Project Coverage 85% 🍏

@yruslan yruslan force-pushed the feature/38-add-scala-2.13-support branch from 9a158ad to af78eff Compare August 1, 2023 08:08
@yruslan yruslan marked this pull request as ready for review August 1, 2023 08:13
Copy link

@lsulak lsulak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I just read the code

@yruslan yruslan merged commit f30dd03 into master Aug 3, 2023
9 checks passed
@yruslan yruslan deleted the feature/38-add-scala-2.13-support branch August 3, 2023 07:16
This was referenced Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants