Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/spline spark agent 729 decouple absa commons #730

Merged
merged 9 commits into from
Aug 2, 2023

Conversation

wajda
Copy link
Contributor

@wajda wajda commented Aug 1, 2023

fixes #729

  • copy/pasted used classes from ABSA Commons to the Agent project
  • Move package "..absa.commons.." to "..absa.spline.commons.."

@github-actions
Copy link

github-actions bot commented Aug 1, 2023

JaCoCo code coverage report

File Coverage [33.23%]
YAMLConfiguration.scala 100% 🍏
MapLikeConfigurationAdapter.scala 100% 🍏
ApiVersionHeader.scala 100% 🍏
SpringClassIdHeader.scala 100% 🍏
LiteralConverter.scala 100% 🍏
ConsoleLineageDispatcher.scala 98.25% 🍏
ReflectiveExtractor.scala 98.13% 🍏
ModelMapperV12.scala 97.71% 🍏
Spline05ConfigurationAdapter.scala 96.64% 🍏
CompositePostProcessingFilter.scala 95.68% 🍏
ModelMapperV11.scala 95.37% 🍏
ObjectStructureDumper.scala 90.64% 🍏
DataSourcePasswordReplacingFilter.scala 90.38% 🍏
ProducerApiCompatibilityManager.scala 89.66% 🍏
AgentConfig.scala 85.2% 🍏
CompositeLineageDispatcher.scala 84.91% 🍏
MetadataCollectingFilter.scala 80.19% 🍏
DataConverter.scala 78.67%
TemplateModel.scala 78.5%
AgentBOM.scala 76.12%
HierarchicalObjectFactory.scala 71.17%
PredicateModel.scala 70.83%
ValueDecomposer.scala 70.59%
ModelMapper.scala 70.21%
ExpressionConverter.scala 68.94%
PlanOperationNodeBuilder.scala 62.28%
Authentication.scala 59.72%
FallbackLineageDispatcher.scala 58.22%
HttpLineageDispatcher.scala 57.83%
SplineRecordSender.scala 54.55%
ProducerApiVersion.scala 48.02%
AbstractJsonLineageDispatcher.scala 40.14%
IOParamsConverter.scala 39.55%
RestEndpoint.scala 30.91%
ModelMapperV10.scala 28.31%
ExprToRefConverter.scala 22.22%
AttributeConverter.scala 20%
HttpLineageDispatcherConfig.scala 15.08%
DefaultIgnoredWriteDetectionStrategy.scala 12.5%
KafkaLineageDispatcher.scala 9.57%
DataTypeConverter.scala 6.76%
SaveIntoDataSourceCommandPlugin.scala 0%
DeltaPlugin.scala 0%
SQLPlugin.scala 0%
MongoPlugin.scala 0%
DatabricksPlugin.scala 0%
DataSourceV2Plugin.scala 0%
ExcelPlugin.scala 0%
BigQueryPlugin.scala 0%
CassandraPlugin.scala 0%
ElasticSearchPlugin.scala 0%
NonPersistentActionsCapturePlugin.scala 0%
CobrixPlugin.scala 0%
JDBCPlugin.scala 0%
XMLPlugin.scala 0%
KafkaPlugin.scala 0%
RDDPlugin.scala 0%
OpenLineageModelMapper.scala 0%
LoggingLineageDispatcher.scala 0%
HttpOpenLineageDispatcher.scala 0%
HDFSLineageDispatcher.scala 0%
UnionNodeBuilder.scala 0%
WindowNodeBuilder.scala 0%
MergeIntoNodeBuilder.scala 0%
OAuthAuthentication.scala 0%
SplineAgent.scala 0%
HttpOpenLineageDispatcherConfig.scala 0%
AutoDiscoveryPluginRegistry.scala 0%
AttributeReorderingFilter.scala 0%
OperationNodeBuilderFactory.scala 0%
LineageHarvester.scala 0%
SparkLineageInitializer.scala 0%
SplineBuildInfo.scala 0%
RestClient.scala 0%
OperationParamsConverter.scala 0%
Total Project Coverage 42.11% 🍏

@wajda wajda marked this pull request as ready for review August 1, 2023 10:36
@wajda wajda requested a review from cerveada August 1, 2023 10:36
cerveada
cerveada previously approved these changes Aug 1, 2023
@wajda wajda force-pushed the feature/spline-spark-agent-729-decouple-absa-commons branch from cfb11ac to 3421004 Compare August 1, 2023 22:40
@wajda wajda force-pushed the feature/spline-spark-agent-729-decouple-absa-commons branch from f6d44c0 to 92bb289 Compare August 1, 2023 23:17
@wajda wajda force-pushed the feature/spline-spark-agent-729-decouple-absa-commons branch from 92bb289 to 88e7e2d Compare August 1, 2023 23:30
@sonarcloud
Copy link

sonarcloud bot commented Aug 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
3.0% 3.0% Duplication

@wajda wajda merged commit 6ef01c6 into develop Aug 2, 2023
19 of 21 checks passed
@wajda wajda deleted the feature/spline-spark-agent-729-decouple-absa-commons branch August 2, 2023 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decouple from Absa Commons and other external dependencies
2 participants