Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple from Absa Commons and other external dependencies #729

Closed
wajda opened this issue Jul 31, 2023 · 0 comments · Fixed by #730
Closed

Decouple from Absa Commons and other external dependencies #729

wajda opened this issue Jul 31, 2023 · 0 comments · Fixed by #730
Assignees
Milestone

Comments

@wajda
Copy link
Contributor

wajda commented Jul 31, 2023

This is a long-term solution for various classpath conflicts when using Spline agent in combination with other Spark extensions or applications. Shading dependencies help to some extent, but not always, and especially when external classes appear in the agent public API (e.g. #723).
To minimize such problems in the future we need:

  1. Make sure the agent public or even developer API do not contain any reference to external classes or interfaces.
  2. Minimize number of external dependencies as much as possible. Copy/paste of some small commons or utility classes and make it a part of our own code base is not necessarily something to be always ashamed of. Everything has its own pros and cons.
@wajda wajda added this to the 1.3.0 milestone Jul 31, 2023
@wajda wajda self-assigned this Jul 31, 2023
wajda added a commit that referenced this issue Aug 1, 2023
wajda added a commit that referenced this issue Aug 1, 2023
wajda added a commit that referenced this issue Aug 1, 2023
wajda added a commit that referenced this issue Aug 1, 2023
wajda added a commit that referenced this issue Aug 1, 2023
wajda added a commit that referenced this issue Aug 1, 2023
wajda added a commit that referenced this issue Aug 1, 2023
wajda added a commit that referenced this issue Aug 1, 2023
wajda added a commit that referenced this issue Aug 1, 2023
wajda added a commit that referenced this issue Aug 1, 2023
wajda added a commit that referenced this issue Aug 1, 2023
wajda added a commit that referenced this issue Aug 1, 2023
@wajda wajda closed this as completed in #730 Aug 2, 2023
wajda added a commit that referenced this issue Aug 2, 2023
* issue #729 Decouple from Absa Commons and other external dependencies

* issue #729 + tests

* issue #729 consolidate commons

* issue #729 move "absa.commons" to "absa.spline.commons"

* issue #729 fix failing tests

* issue #729 remove deprecated methods

* issue #729 POM: Fix an oversight in the dependency name (hardcoded scala version)

* issue #729 Optimize imports

* issue #729 Increment project version to 2.0.0-SNAPSHOT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant