Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consumer API: Data Source filters are counter-intuitive #969

Closed
wajda opened this issue Oct 4, 2021 · 0 comments
Closed

Consumer API: Data Source filters are counter-intuitive #969

wajda opened this issue Oct 4, 2021 · 0 comments
Assignees
@wajda
Labels
bug component: Consumer
Milestone
0.7.3

Comments

@wajda
Copy link
Contributor

wajda commented Oct 4, 2021

Currently the Last Executed relation is outer joined to the Data Source. It usually makes sense unless at least one of the Execution related filters is applied to the query. In that case the logic should correspond to an inner join instead.

For example, when I as a user enable the datetime filter I expect to only see those data sources whose associated Last Executed event satisfies the given date time criteria. The same holds for other Execution related filters like writeMode for instance.
@wajda wajda added this to the 0.7.3 milestone Oct 4, 2021
@wajda wajda self-assigned this Oct 4, 2021
@wajda wajda changed the title Consumer API: Data Source "writeMode" and "datetime" filters are counter-intuitive Consumer API: Data Source filters are counter-intuitive Oct 4, 2021
wajda added a commit that referenced this issue Oct 4, 2021
@wajda
spline #969 Consumer API: Data Source list: apply INNER JOIN logic wh…
d3d84f8 
…en at least one filter is enabled
wajda added a commit that referenced this issue Oct 4, 2021
@wajda
spline #969 remove redundant collection locks
06465df
wajda added a commit that referenced this issue Oct 4, 2021
@wajda
spline #969 rename variable
4ee608f
@wajda wajda mentioned this issue Oct 4, 2021
Merged
wajda added a commit that referenced this issue Oct 4, 2021
@wajda
spline #969 Consumer API: Data Source list: apply INNER JOIN logic wh… (
771eb59 
#970)

* spline #969 Consumer API: Data Source list: apply INNER JOIN logic when at least one filter is enabled

* spline #969 remove redundant collection locks

* spline #969 rename variable
@wajda wajda closed this as completed Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wajda wajda

Labels
bug component: Consumer
Projects
Spline
Status: Done
Milestone
0.7.3
Development

No branches or pull requests
1 participant
@wajda