Allow funds to be transferred to module on instantiation #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
3e0ae38
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ab15b965.abstract-docs.pages.dev |
| Branch Preview URL: | https://misha-abs-177-allow-funds-to.abstract-docs.pages.dev |
CyberHoward
reviewed
Sep 6, 2023
CyberHoward
reviewed
Sep 7, 2023
CyberHoward
reviewed
Sep 7, 2023
| @@ -286,14 +304,15 @@ impl ModuleConfiguration { | |||
|
|
|||
| pub fn from_storage(storage: &dyn Storage, module: &ModuleInfo) -> Self { | |||
There was a problem hiding this comment.
These are at least 3 load operations for a single module. Can we combine their information into a single data store so we only have to load once?
There was a problem hiding this comment.
Yep, changed storage to have distinct map for "default" items for module config as well!
CyberHoward
reviewed
Sep 7, 2023
CyberHoward
reviewed
Sep 7, 2023
CyberHoward
deleted the
misha/abs-177-allow-funds-to-be-transferred-to-module-on-instantiation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the title
Checklist