Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flush state function for local daemons #401

Merged
merged 4 commits into from
Jun 4, 2024
Merged

Add flush state function for local daemons #401

merged 4 commits into from
Jun 4, 2024

Conversation

Kayanski
Copy link
Contributor

This PR aims at introducing a state flushing method for local chain Daemons

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented May 21, 2024 •
edited
Loading

Deploying cw-orchestrator with  Cloudflare Pages  Cloudflare Pages

Latest commit: 581486b
Status:⚡️  Build in progress...

View logs

@codecov Codecov
Copy link

codecov bot commented May 21, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 64.4%. Comparing base (41fc930) to head (3222c8c).

Additional details and impacted files
Files Coverage Δ
cw-orch-daemon/src/core.rs 57.7% <0.0%> (-0.9%) ⬇️
cw-orch-daemon/src/sync/core.rs 67.5% <0.0%> (-2.0%) ⬇️
cw-orch-daemon/src/state.rs 82.6% <0.0%> (-6.4%) ⬇️

@Kayanski Kayanski requested a review from Buckram123 May 21, 2024 09:13
Buckram123
Buckram123 requested changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@Buckram123 Buckram123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool feature! Need to make it work without state

cw-orch-daemon/src/state.rs Show resolved Hide resolved
Buckram123
Buckram123 approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@Buckram123 Buckram123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kayanski Kayanski merged commit 417d318 into main Jun 4, 2024
14 of 15 checks passed
@Kayanski Kayanski deleted the nicolas/orc-135-add-a-state-flush-method-to-daemon branch June 4, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Buckram123 Buckram123 Buckram123 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kayanski @Buckram123