Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead code from half #179

Merged
merged 2 commits into from
Jul 8, 2021

Conversation

cary-ilm
Copy link
Member

@cary-ilm cary-ilm commented Jul 8, 2021

  • move eLut.h, imath_float_half_exp_table, and long_convert to
    ImathTest. They're useful to validate behavior in the test but have
    no use in the actual library.

Signed-off-by: Cary Phillips cary@ilm.com

* move eLut.h, imath_float_half_exp_table, and long_convert to
  ImathTest. They're useful to validate behavior in the test but have
  no use in the actual library.

Signed-off-by: Cary Phillips <cary@ilm.com>
Signed-off-by: Cary Phillips <cary@ilm.com>
Copy link
Contributor

@kdt3rd kdt3rd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning things up - I was a bit chicken to change too much without being able to go back. Since you have the branch, could you also remove the definition of long_convert from half.h? I don't see that in the diffs.

src/Imath/half.h Show resolved Hide resolved
@cary-ilm
Copy link
Member Author

cary-ilm commented Jul 8, 2021

I don't see any reason to be hesitant, the changes are demonstrable improvements so better to fully commit to them and make the code as clear as possible. It's easy enough to recover the old code from past release branches. And the old code is still present in the test as well.

Actually, rather than making the performance test execute both new and old code, it might be simpler to write a single routine that measures performance and then patch it into the RB-3.0 branch. Then measure the difference with separate runs built against different branches. It would also provide an easier way of measuring future changes.

@cary-ilm cary-ilm merged commit 1f3f064 into AcademySoftwareFoundation:master Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants