Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docs race condition and make installation optional #222

Merged
merged 2 commits into from
Oct 28, 2021
Merged

Fix docs race condition and make installation optional #222

merged 2 commits into from
Oct 28, 2021

Conversation

hobbes1069
Copy link
Contributor

  • Fixes race condition in Doxygen.
  • Makes installation of documentation option for ease of packaging.

@hobbes1069
Fix docs race condition and make installation optional
27e908e 
* Fixes race condition in Doxygen.
* Makes installation of documentation option for ease of packaging.
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 26, 2021 •
edited

CLA Signed

The committers are authorized under a signed CLA.

@hobbes1069 hobbes1069 mentioned this pull request Oct 26, 2021
Closed
@cary-ilm
Copy link
Member

Thanks for this, and it looks good to me.

Our contribution policies require signed commits (DCO), could you recommit this with "commit -s", or add a "Signed-off-by: yourname" to the commit message?

@hobbes1069
Copy link
Contributor Author

I'll give it a shot. I haven't had to do that before :) I was hoping signing the CLA was sufficient!

@hobbes1069
Fix docs race condition and make installation optional
b2e3ec2 
* Fixes race condition in Doxygen.
* Makes installation of documentation option for ease of packaging.

Signed-off-by: Richard Shaw <hobbes1069@gmail.com>
@cary-ilm
Copy link
Member

Thanks!

@cary-ilm cary-ilm merged commit 8ea162e into AcademySoftwareFoundation:master Oct 28, 2021
cary-ilm added a commit to cary-ilm/openexr that referenced this pull request Oct 28, 2021
@cary-ilm
Replace Doxygen/Sphinx targets with "docs"
97c0923 
Similar to
AcademySoftwareFoundation/Imath#222, this
avoids a race condition bug in Doxygen
(doxygen/doxygen#6293) when CMake builds
simultaneously for multiple architectures.

Also, don't include the docs when OpenEXR is a subproject, because the
target can conflict with a target in the parent project, and the
parent project shouldn't need the OpenEXR docs, anyway.

Signed-off-by: Cary Phillips <cary@ilm.com>
@cary-ilm cary-ilm mentioned this pull request Oct 28, 2021
Merged
cary-ilm added a commit to AcademySoftwareFoundation/openexr that referenced this pull request Nov 3, 2021
@cary-ilm
Replace Doxygen/Sphinx targets with "docs" (#1191)
505f2bc 
Similar to
AcademySoftwareFoundation/Imath#222, this
avoids a race condition bug in Doxygen
(doxygen/doxygen#6293) when CMake builds
simultaneously for multiple architectures.

Also, don't include the docs when OpenEXR is a subproject, because the
target can conflict with a target in the parent project, and the
parent project shouldn't need the OpenEXR docs, anyway.

Signed-off-by: Cary Phillips <cary@ilm.com>
cary-ilm pushed a commit to cary-ilm/Imath that referenced this pull request Jan 17, 2022
@hobbes1069 @cary-ilm
Fix docs race condition and make installation optional (AcademySoftwa…
a5b2ddc 
…reFoundation#222)

* Fix docs race condition and make installation optional
* Fixes race condition in Doxygen.
* Makes installation of documentation option for ease of packaging.

* Fix docs race condition and make installation optional

* Fixes race condition in Doxygen.
* Makes installation of documentation option for ease of packaging.

Signed-off-by: Richard Shaw <hobbes1069@gmail.com>
cary-ilm added a commit to cary-ilm/openexr that referenced this pull request Jan 19, 2022
@cary-ilm
Replace Doxygen/Sphinx targets with "docs" (AcademySoftwareFoundation…
3e9dfc7 
…#1191)

Similar to
AcademySoftwareFoundation/Imath#222, this
avoids a race condition bug in Doxygen
(doxygen/doxygen#6293) when CMake builds
simultaneously for multiple architectures.

Also, don't include the docs when OpenEXR is a subproject, because the
target can conflict with a target in the parent project, and the
parent project shouldn't need the OpenEXR docs, anyway.

Signed-off-by: Cary Phillips <cary@ilm.com>
cary-ilm pushed a commit that referenced this pull request Jan 20, 2022
@hobbes1069 @cary-ilm
Fix docs race condition and make installation optional (#222)
1ddf327 
* Fix docs race condition and make installation optional
* Fixes race condition in Doxygen.
* Makes installation of documentation option for ease of packaging.

* Fix docs race condition and make installation optional

* Fixes race condition in Doxygen.
* Makes installation of documentation option for ease of packaging.

Signed-off-by: Richard Shaw <hobbes1069@gmail.com>
cary-ilm added a commit to AcademySoftwareFoundation/openexr that referenced this pull request Jan 23, 2022
@cary-ilm
Replace Doxygen/Sphinx targets with "docs" (#1191)
4c310e6 
Similar to
AcademySoftwareFoundation/Imath#222, this
avoids a race condition bug in Doxygen
(doxygen/doxygen#6293) when CMake builds
simultaneously for multiple architectures.

Also, don't include the docs when OpenEXR is a subproject, because the
target can conflict with a target in the parent project, and the
parent project shouldn't need the OpenEXR docs, anyway.

Signed-off-by: Cary Phillips <cary@ilm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
v3.1.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hobbes1069 @cary-ilm