Added CI testing and made necessary changes to pass those tests. #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Owen Thompson <oxt3479@rit.edu>
Signed-off-by: Owen Thompson <oxt3479@rit.edu>
Signed-off-by: Owen Thompson <oxt3479@rit.edu>
…zed variables. Signed-off-by: Owen Thompson <oxt3479@rit.edu>
Signed-off-by: Owen Thompson <oxt3479@rit.edu>
Signed-off-by: Owen Thompson <oxt3479@rit.edu>
Signed-off-by: Owen Thompson <oxt3479@rit.edu>
| cc-compiler: clang | ||
| compiler-desc: Clang 7 | ||
| vfx-cy: 2019 | ||
| exclude-tests: |
There was a problem hiding this comment.
Would be great to also add VFX-2021 to check newer clang-10 and gcc-9.3.1
|
The github actions files and sonar project properties file LGTM! |
xlietz
approved these changes
Jul 22, 2020
cary-ilm
approved these changes
Jul 22, 2020
lgritz
reviewed
Jul 23, 2020
lgritz
reviewed
Jul 23, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with CI identical to that of OpenEXR, this testing infrastructure was adapted to work for the Imath repository.
Changes made to constexpr previously (after separation from openEXR) caused issues with both the clang++ and g++-6.3.1 compilers used in the VFX CI. This required few changes in order to get CI to pass. Now all tests should pass.