Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding missing header #70

Merged
merged 1 commit into from
Dec 12, 2020
Merged

Adding missing header #70

merged 1 commit into from
Dec 12, 2020

Conversation

bareya
Copy link
Contributor

@bareya bareya commented Dec 11, 2020

When I try to build the library with g++-4.8 on CentOS-7 I get following error:

git/Imath/src/Imath/ImathVec.h: In member function ‘const Imath_3_0::Vec2<T>& Imath_3_0::Vec2<T>::normalizeExc()’:
git/Imath/src/Imath/ImathVec.h:1102:15: error: ‘domain_error’ is not a member of ‘std’

Adding necessary header file(<stdexcept>) to ImathVec.h solves the problem.

@bareya
Adding missing header
c9a8126 
Signed-off-by: Piotr Barejko <piotrbarejko@protonmail.com>
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 11, 2020 •
edited

CLA Signed

The committers are authorized under a signed CLA.

lgritz
lgritz approved these changes Dec 11, 2020
View reviewed changes
Copy link
Contributor

@lgritz lgritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending receipt of the CLA

@lgritz
Copy link
Contributor

lgritz commented Dec 11, 2020

@bareya To add the DCO, just try git commit --amend -s and then do a force push.

@bareya
Copy link
Contributor Author

bareya commented Dec 11, 2020 •
edited

@lgritz I think DCO is completed, waiting for CI to complete.

@lgritz lgritz merged commit 375a572 into AcademySoftwareFoundation:master Dec 12, 2020
@JenusL JenusL mentioned this pull request Oct 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lgritz lgritz lgritz approved these changes

Assignees
No one assigned
Labels
v3.0.0-beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bareya @lgritz @cary-ilm