Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lucasfilm] Multiple Scattering Compensation In Generated GLSL #403

Closed
jstone-lucasfilm opened this issue Apr 9, 2020 · 1 comment
Closed

[Lucasfilm] Multiple Scattering Compensation In Generated GLSL #403

jstone-lucasfilm opened this issue Apr 9, 2020 · 1 comment

Comments

@jstone-lucasfilm
Copy link
Member

This task represents additional work to compensate for multiple scattering in MaterialX-generated GLSL, building upon recent improvements to energy conservation (#402), and using the following references as a guide:

https://blog.selfshadow.com/publications/s2017-shading-course/imageworks/s2017_pbs_imageworks_slides_v2.pdf
https://blog.selfshadow.com/publications/turquin/ms_comp_final.pdf
https://blog.selfshadow.com/2018/05/13/multi-faceted-part-1/
@jstone-lucasfilm jstone-lucasfilm mentioned this issue Apr 13, 2020
Merged
@jstone-lucasfilm
Copy link
Member Author

This has been addressed in pull request #407

lvxejay pushed a commit to ForgeXYZ/MaterialX that referenced this issue Jul 9, 2020
@bernardkwok
Compositing operation implementation fixes (AcademySoftwareFoundation…
8393927 
…#403)

* Fix compositing tests to give results that can be compared. Mostly avoid > 1 and non opaque final outputs.
Also avoid divide by 0 for some functions like burn, dodge, disjoint-over which requires implementation safe-guards.

* Fix compositing tests to give results that can be compared. Mostly avoid > 1 and non opaque final outputs.
Also avoid divide by 0 for some functions like burn, dodge, disjoint-over which requires implementation safe-guards.

* Burn and dodge for genosl.

* Redo disjointover for OSL.

* GLSL impls for burn, dodge, disjointover.

* Add divide by zero tests for burn, dodge, disjointover.

* Fix tabs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jstone-lucasfilm