Add normal to gltf_pbr translation graph #1234
Conversation
| @@ -17,6 +17,7 @@ | |||
| <input name="coat_roughness" type="float" value="0.1" /> | |||
| <input name="emission" type="float" value="0" /> | |||
| <input name="emission_color" type="color3" value="1, 1, 1" /> | |||
| <input name="normal" type="vector3" value="0.5, 0.5, 1.0" /> | |||
There was a problem hiding this comment.
The value seems to come from the Standard Surface to UsdPreviewSurface translation graph, and I don't think it is correct in this context. We should use defaultgeomprop="Nworld" instead.
|
While we're at it, I think we should add support for the tangent input in a similar way! |
|
@rasmusbonnedal This looks like a step in the right direction, but as @pablode notes, we'll need to handle the novel situation that both Standard Surface and glTF PBR take world-space normal inputs rather than tangent-space values. In addition to the default value change that Pablo suggests above, I believe we'd need to refine the logic that optimizes away inputs at their default values during texture baking, adding handling for the |
|
@rasmusbonnedal Feel free to continue working on this if you have the bandwidth, but I'll close out the original PR for now, since additional work would be needed to make it fully robust. |
No description provided.