Add Python bindings for TargetDef and AttributeDef #1241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c missing entries on document.
|
@niklasharrysson, I needed targetdef, but noticed that attributedef was missing so added that in as well. The test here is just for a string metadata attribute (borrowed from the C++ test). |
jstone-lucasfilm
changed the title
jstone-lucasfilm
approved these changes
Mar 24, 2023
There was a problem hiding this comment.
Thanks for putting this change together, @kwokcb, and it looks good to me!
Michaelredaa
pushed a commit
to Michaelredaa/MaterialX
that referenced
this pull request
Oct 21, 2023
…undation#1241) - Add in AttributeDef Python interface - Add in TargetDef Python interface - Add in missing Python interfaces on Document and ShaderGenerator using these interface and metadata registration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are no new C++ APIs. They are just missing from the Python API
Changes
AttributeDefPython interfaceTargetDefPython interfaceDocumentandShaderGeneratorusing these interface and metadata registrationTest
genshaderPython test to testTargetDefto find targets and match against the sahder generatorgensahdertest to add customAttributeDefand test that they make it through OSL code gen. Resulting code should have custom string datanode_namewhich is associated with the std surface nodedef:surface standardSurface1 [[ string mtlx_category = "standard_surface", string mtlx_name = "standardSurface1", string help = "Autodesk standard surface shader", string node_name = "Standard_Surface_Number_1" ]]