-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Graph I/O Support #1263
Closed
Closed
Graph I/O Support #1263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@kwokcb With the recent contribution of Metal support, you may need to update this changelist to accommodate the refactoring of GLSL/MSL rendering functionality. |
Thanks for the heads up. Merge wasn't too bad :). |
|
/easycla |
Closing this for refactoring. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GraphIo
SupportAdd a new utility class to support graph parsing and interchange. For now this is only used for output graph parsing with targets being
mermaid
andGraphViz dot
graphs which are implemented as classes derived from NodeGraphIOSupport added:
GraphIo
input
->interfacename
andoutput
->output
pass-throughs)option as it's only a UI thing or we look at making NodeDef<->Node caching faster.
PyGraphIo
,PyDotGraphIo
,PyMermadGraphIo
mxgraph.py
which allows for Mermaid and dot output option.GraphIo
,DotGraphIo
,MermaidlGraphIo
nodegraph
s and documentation generation outputting both category or instance identifier variants. Produces results per definition in all core libraries into a sperate folder in the test area.mxdoc
modified to have--nodegraph
option for Markdown and HTML output.mxdoc
tests.mxgraph
to create graphs from any document. Test added to run with chess set.dot
output forMaterialXView
which does not work currently with usage of GraphIO Mermaid and GraphiViz output options.Results
Functional
nodegraph
smxdoc.py
mxdoc.py
. Mermaid graph inside HTML output, withusing
DoxygenAwesome
CSS fileEquivalent prodduced in unit tests (GraphViz output)
GraphViz Results:
Mermaid Results:
is not cheap to find the corresponding NodeDef for a Node.