Updated MaterialXTest to improve MDL support #1277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
krohmerNV
commented
Mar 13, 2023
krohmerNV
commented
- changed the MDL test renderer to be used with Example DXR (shipped with the MDL SDK)
- with that, added a gltf sphere and a rotated hdri to get a closely matching scene setup
- extended the tests_to_html script for a three-way-comparison
- added a preprocessing step in the test to allow mdlgen to use flattenFilenames for application side resource handling
- replaced element->getActiveSourceUri() by doc->getSourceUri() because of failures with standard_surface_look_* tests
kwokcb
reviewed
Mar 15, 2023
krohmerNV
commented
Mar 15, 2023
krohmerNV
force-pushed
the
PR-MDL-update-materialxtests
branch
from
9c621a9
to
176b00a
Compare
- changed the MDL test renderer to be used with Example DXR (shipped with the MDL SDK) - with that, added gltf sphere and a rotated hdri to get a closely matching scene setup - extended the tests_to_html script for a three-way-comparison - added a preprocessing step in the test to allow mdlgen to use flattenFilename for application side resource handling - replaced element->getActiveSourceUri() by doc->getSourceUri() because of failures with standard_surface_look_* tests
We can revisit this as developers begin integrating MDL into their standard render tests. Signed-off-by: Jonathan Stone <jstone@lucasfilm.com>
krohmerNV
force-pushed
the
PR-MDL-update-materialxtests
branch
from
176b00a
to
35a0a84
Compare
Signed-off-by: Jonathan Stone <jstone@lucasfilm.com>
Signed-off-by: Jonathan Stone <jstone@lucasfilm.com>
Signed-off-by: Jonathan Stone <jstone@lucasfilm.com>
|
I believe I addressed all issues with this PR.
|
|
Thanks for those updates, @krohmerNV, and this changelist looks ready to go. I'd just wanted to run some local tests before merging, but otherwise this looks good to me. |
jstone-lucasfilm
approved these changes
Apr 6, 2023
jstone-lucasfilm
merged commit abc1f83
into
AcademySoftwareFoundation:main
12 checks passed
Michaelredaa
pushed a commit
to Michaelredaa/MaterialX
that referenced
this pull request
Oct 21, 2023
…on#1277) - changed the MDL test renderer to be used with Example DXR (shipped with the MDL SDK) - extended the tests_to_html script for a three-way-comparison - added a preprocessing step in the test to allow mdlgen to use flattenFilenames for application side resource handling - replaced element->getActiveSourceUri() by doc->getSourceUri() because of failures with standard_surface_look_* tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.