Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MSL render test when no lights are present #1290

Conversation

Morteeza
Copy link
Contributor

No description provided.

@Morteeza Morteeza force-pushed the no_active_light_test_failure branch from 7659796 to bf4294b Compare March 20, 2023 12:05
@jstone-lucasfilm jstone-lucasfilm changed the title Fixes MSL render test failure when no active light existed, but lighting was requested. Fix MSL render test when no lights are present Mar 20, 2023
Copy link
Member

@jstone-lucasfilm jstone-lucasfilm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @Morteeza!

@jstone-lucasfilm jstone-lucasfilm merged commit 9bb45dd into AcademySoftwareFoundation:main Mar 20, 2023
krohmerNV pushed a commit to krohmerNV/MaterialX that referenced this pull request Apr 5, 2023
Michaelredaa pushed a commit to Michaelredaa/MaterialX that referenced this pull request Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants